[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: sed porting trouble

From: Eric Blake
Subject: Re: Fwd: sed porting trouble
Date: Tue, 05 Oct 2010 05:55:48 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 10/05/2010 04:49 AM, Jim Meyering wrote:
Thus, technically we must now remember that for each new
@address@hidden .in.h file, we must also use @address@hidden

That deserves a syntax-check rule in Makefile.

Makes sense to me.

I've added this:
+       if test -d .git; then                                           \
+          git ls-files|grep '\.in\.h$$'                                        

Hmm - in coreutils' case where gnulib is a submodule, 'git ls-files' doesn't recurse into the submodule, so you won't have any coverage of the *.in.h files when running 'make syntax-check' in coreutils. And I'm not sure how often, if it is even possible, that 'make syntax-check' gets run directly on gnulib. Does this rule need a bit of tweaking to ensure that it visits gnulib files even when they don't belong to the VCS of the project that included gnulib as a submodule?

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]