[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: sed porting trouble

From: Eric Blake
Subject: Re: Fwd: sed porting trouble
Date: Mon, 04 Oct 2010 07:49:23 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 10/02/2010 04:07 AM, Bruno Haible wrote:
Hi Joachim,

The problem is that the -Wcolumns=... doesn't seem to override the pragmas in
the source.

Yes, that's clear from the documentation that you pointed us to.

I'd rather see lines of 80 chars or shorter than adding pragmas all over the 

Not me.

Personally, I don't mind a two-pronged approach:

Lines less than 80 columns are nicer in my opinion, and we might as well do that whether or not -Wcolumns is in effect when the end result looks nicer. But I agree with Bruno that some lines should not be broken, as breaking them makes them less readable, and that we shouldn't have to worry about whether a particular commit is going to resurrect the problem. Therefore, using the #pragma will make the code immune to column width, whether or not we also reduce line length.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]