[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/7] gnulib-tool: transform hard-coded libgnu.a to $libname.l

From: Bruno Haible
Subject: Re: [PATCH 2/7] gnulib-tool: transform hard-coded libgnu.a to $libname.l?a
Date: Tue, 12 Oct 2010 22:26:18 +0200
User-agent: KMail/1.9.9

Hi Gary,

> * gnulib-tool (func_emit_lib_Makefile_am): transform hard-coded
> `libgnu.a' in Makefile.am snippets to be either `$libname.a' or
> `$libname.la', depending on whether --libtool/--no-libtool options
> were given.

Here it's clear that we need a way to combine the module description
of 'pt_chown' with information that only gnulib-tool knows. But rather
than having a magic token 'libgnu.a', I would prefer to make it more
extensible. In particular, I would change modules/pt_chown so that it
   pt_chown_LDADD = ${gl_libname}.${gl_libext}
and have gnulib-tool recognize the two magic tokens

It already replaces ${gl_m4_base} in the configure.ac section of a
module description (albeit through a different mechanism).

And, please, in gnulib code, we don't use tabs any more, except in pieces
of Makefiles and ChangeLog. See the section "Indent with spaces, not TABs"
of gnulib/README.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]