[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/7] gnulib-tool: transform hard-coded libgnu.a to $libname.l

From: Gary V. Vaughan
Subject: Re: [PATCH 2/7] gnulib-tool: transform hard-coded libgnu.a to $libname.l?a
Date: Wed, 13 Oct 2010 16:40:25 +0700

On 13 Oct 2010, at 03:26, Bruno Haible wrote:
>> * gnulib-tool (func_emit_lib_Makefile_am): transform hard-coded
>> `libgnu.a' in Makefile.am snippets to be either `$libname.a' or
>> `$libname.la', depending on whether --libtool/--no-libtool options
>> were given.
> Here it's clear that we need a way to combine the module description
> of 'pt_chown' with information that only gnulib-tool knows. But rather
> than having a magic token 'libgnu.a', I would prefer to make it more
> extensible. In particular, I would change modules/pt_chown so that it
> does
>   pt_chown_LDADD = ${gl_libname}.${gl_libext}
> and have gnulib-tool recognize the two magic tokens
>  ${gl_libname}
>  ${gl_libext}
> It already replaces ${gl_m4_base} in the configure.ac section of a
> module description (albeit through a different mechanism).

Sure, that seems like a better separation of concerns, and on
reflection I agree that non-obvious magic tokens soon lead to
maintenance problems.

> And, please, in gnulib code, we don't use tabs any more, except in pieces
> of Makefiles and ChangeLog. See the section "Indent with spaces, not TABs"
> of gnulib/README.

My bad.  I knew this already actually, but used vi to fix up some of
the patches during testing instead of my usual emacs... sorry about

Does vim have an equivalent to emacs' (setq-default indent-tabs-mode nil)
that I could paste into my .vimrc to save me from doing this again?

Gary V. Vaughan (address@hidden)

Attachment: PGP.sig
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]