[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: -Werror in tests

From: Bruno Haible
Subject: Re: -Werror in tests
Date: Sun, 17 Oct 2010 23:36:21 +0200
User-agent: KMail/1.9.9

Hi Jim,

> With that, I can enable -Werror in coreutils' gnulib-tests directory.

Only on glibc systems, I hope? On other platforms, there will be lots of other
warnings that I don't want to deal with individually.

Globally, I don't think it is such a good move. We need more unit tests,
and with a limited amount of time, I think it is better to write 2
"quick & dirty" style tests than 1 polished and warning-free test.
Therefore I'm not in favour of requiring a 100% warning-free tests directory
with various kinds of gcc warnings. If a test gives no warnings with
"gcc -Wall", and has a couple of comments, that's all I would demand
from a test.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]