[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: parse-duration-tests: make it build
From: |
Bruce Korb |
Subject: |
Re: parse-duration-tests: make it build |
Date: |
Thu, 21 Jun 2012 13:46:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
On 06/21/12 12:41, Bruno Haible wrote:
Your commit came without a ChangeLog entry. I added one for you:
Woops. Thanks you so much!
On 06/21/12 12:41, Bruno Haible wrote:
Or, even better in my opinion: All the trouble has been caused my the
desire to keep a shell script and a data table in the same file. Separate
them. Move the test data into a file of its own, say
tests/test-parse-duration-data.txt. Then you don't need a temporary dir,
you don't need a 'trap' command, just a
while read line< ${srcdir}/test-parse-duration-data.txt
Except for the file being re-opened on each iteration,
that is a good idea. In general, though, when I use a here doc,
I use the strip-the-tabs form because it looks _much_ cleaner.
In this case, this:
while read line ; do
...
done < ${srcdir}/test-parse-duration-data.txt
combined with the trap handling removal is a lot better.
- parse-duration-tests: make it build, Simon Josefsson, 2012/06/20
- Re: parse-duration-tests: make it build, Bruno Haible, 2012/06/20
- Re: parse-duration-tests: make it build, Bruce Korb, 2012/06/21
- Re: parse-duration-tests: make it build, Jim Meyering, 2012/06/21
- Re: parse-duration-tests: make it build, Bruce Korb, 2012/06/21
- Re: parse-duration-tests: make it build, Jim Meyering, 2012/06/21
- Re: parse-duration-tests: make it build, Bruce Korb, 2012/06/21
- Re: parse-duration-tests: make it build, Jim Meyering, 2012/06/21
- Re: parse-duration-tests: make it build, Bruno Haible, 2012/06/21
- Re: parse-duration-tests: make it build,
Bruce Korb <=
- Re: parse-duration-tests: make it build, Bruce Korb, 2012/06/21
- Re: parse-duration-tests: make it build, Jim Meyering, 2012/06/21
- Re: parse-duration-tests: make it build, Bruno Haible, 2012/06/21