[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: poll() emulation in git
From: |
Paolo Bonzini |
Subject: |
Re: poll() emulation in git |
Date: |
Thu, 06 Sep 2012 17:15:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 06/09/2012 16:44, Joachim Schmitz ha scritto:
>> > Yes, it's an usleep(autocorrect * 100000) basically (poll takes
>> > milliseconds, not micro).
> OK, it is _supposed_ to do this usleep(), but is does not, as poll() returns
> early with EFAULT in this case:
> /* EFAULT is not necessary to implement, but let's do it in the
> simplest case. */
> if (!pfd)
> {
> errno = EFAULT;
> return -1;
> }
>
> poll() is doing this before calling select(), so won't sleep.
> So there's a bug in {gnulib|git}'s poll(), right?
>
Yes, it should be "if (!pfd && nfd)".
Paolo
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/05
- Re: poll() emulation in git, Bastien ROUCARIES, 2012/09/05
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/05
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/06
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/06
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/06
- Re: poll() emulation in git,
Paolo Bonzini <=
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/07
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/07
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/07