[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: poll() emulation in git
From: |
Joachim Schmitz |
Subject: |
RE: poll() emulation in git |
Date: |
Fri, 7 Sep 2012 09:23:59 +0200 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> Sent: Thursday, September 06, 2012 5:15 PM
> To: Joachim Schmitz
> Cc: address@hidden; 'Junio C Hamano'; 'Erik Faye-Lund'; address@hidden;
> address@hidden
> Subject: Re: poll() emulation in git
>
> Il 06/09/2012 16:44, Joachim Schmitz ha scritto:
> >> > Yes, it's an usleep(autocorrect * 100000) basically (poll takes
> >> > milliseconds, not micro).
> > OK, it is _supposed_ to do this usleep(), but is does not, as poll()
> > returns early with EFAULT in this case:
> > /* EFAULT is not necessary to implement, but let's do it in the
> > simplest case. */
> > if (!pfd)
> > {
> > errno = EFAULT;
> > return -1;
> > }
> >
> > poll() is doing this before calling select(), so won't sleep.
> > So there's a bug in {gnulib|git}'s poll(), right?
> >
>
> Yes, it should be "if (!pfd && nfd)".
Are you going to fix this in gnulib?
Bye, Jojo
- Re: poll() emulation in git, (continued)
- Re: poll() emulation in git, Bastien ROUCARIES, 2012/09/05
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/05
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/05
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/06
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/06
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/06
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/06
- RE: poll() emulation in git,
Joachim Schmitz <=
- RE: poll() emulation in git, Joachim Schmitz, 2012/09/07
- Re: poll() emulation in git, Paolo Bonzini, 2012/09/07