Re: fix for source includes in gendoc.sh for future consideration

[Patrice Dumas]

On Sun, Jan 28, 2024 at 07:06:10PM +0100, Bruno Haible wrote:
> Hi Patrice,
> 
> > It may be strange to apply it now, before the Texinfo release, however.  I
> > can re-propose it after the Texinfo release, you tell me.
> 
> It's unlikely that the --trace-includes features gets removed again before
> the texinfo 7.2 release, right?

Very unlikely, Gavin revised the manual.  The release number could be
8.0, though, but the patch would still be ok.

> Then it's OK to commit a patch like this into Gnulib now.

Ok.

I have attched an updated version with the changes in indentation.

> But
> 
>   - The 'case' statement is misindented: should indent by 2, not 3 spaces.

Ok.

>   - What's the point of the 'eval'? Can't you get rid of it? And if not,
>     then make it safer by writing
>       cmd="\\$SETLANG \\$MAKEINFO \\$commonarg --trace-includes \"\\$base\""

I am not competent enough to know what to do here, I just mimicked the
other MAKEINFO invokations.  I think that the eval is to get quoting
right, but that is a wild guess.  I could use your code here, but I
didn't as I think that it should not be changed at that occasion, but
rather all the $MAKEINFO invokations should be changed consistently.
However, do not hesitate to make the change if you think that it is
better.

>   - Better indentation: Hiding the command name 'tar' in the middle of a line
>     is not ideal, when this command spans multiple lines. Also, the GNU
>     standards favour listing the operators at the beginning of a line, not
>     at the end. I mean, change
> 
>     eval "$cmd" | tar -czhf "$abs_outdir/$PACKAGE.texi.tar.gz" \
>       --verbatim-files-from -T- -- "$base" $pats \
>       ${source_extra+"$source_extra"} &&
>     ls -l "$abs_outdir/$PACKAGE.texi.tar.gz"
> 
>     to
> 
>     eval "$cmd" \
>     | tar -czhf "$abs_outdir/$PACKAGE.texi.tar.gz" \
>         --verbatim-files-from -T- -- "$base" $pats \
>         ${source_extra+"$source_extra"} \
>     && ls -l "$abs_outdir/$PACKAGE.texi.tar.gz"

Ok.

-- 
Pat

gendocs_trace_includes_files_from.diff
Description: Text Data