bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in NSGeometry.m


From: Andrew Ruder
Subject: Re: Changes in NSGeometry.m
Date: Thu, 18 Aug 2005 09:35:57 -0500
User-agent: Mozilla Thunderbird 1.0RC1 (X11/20041201)

Matthias Hengartner wrote:
as I already mentioned, the functions NSStringFromRect, NSStringFromPoint
and NSStringFromSize produce a format, that is not readably by the
NSRectFromString etc. on OPENSTEP.
There are only minor changes (add spaces before and after the "=") to make
it compatible to OPENSTEP (and keep it compatible to GNUstep and MacOSX).

Generally when you post a patch to something, you should put it in unified diff format. I usually do something like this:

diff -uNr gnustep-orig gnustep-working

The -u flag is essential to get the unified diff format. With CVS, you can do a

cvs diff -u

to get the diff against latest cvs in unified format. Unified diffs give more context information on the changes allowing the patches to be much more forgiving when applying agsinst modified files as well as easier to review.

Cheers,
Andy

--
Andrew Ruder <address@hidden>
http://www.aeruder.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]