[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

patch for fixes in NSToolbar and related

From: Wolfgang Sourdeau
Subject: patch for fixes in NSToolbar and related
Date: Wed, 30 Nov 2005 16:45:34 -0500
User-agent: Mutt/1.3.28i


This patch fixes the following problems:

- the generated menus for toolbars were given entries for unlabelled
  standard items: separators, spaces and flexible spaces

- whenever the cell type would change, the _contents ivar would be set
  to @"title". I changed it to do that only when _contents is unset.
  Besides, I was not sure if setting @"title" was very useful but I let
  it that way in case there was a reason. This fixes the case where
  NSToolbar with displayMode set to LabelOnly would redefine the item
  labels to "title".

- in GSToolbarButton's layout method:
  the size for the cell of labelled toolbar items would take the label
  size into account even when the toolbar display mode was set to
- in NSToolbarItem's initWithItemIdentifier: method:
  a double negation in the test on itemIdentifier was causing the item
  never to be reinited to a GSToolbarSeparatorItem.

"An eye for an eye only makes the world blind." (Gandhi)

Attachment: toolbarfixes.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]