[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch for fixes in NSToolbar and related

From: Fred Kiefer
Subject: Re: patch for fixes in NSToolbar and related
Date: Mon, 05 Dec 2005 00:08:27 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050921

Hi Wolfgang,

I see two problems with that patch. First you should not change the
whitespace in a file, this leads to patches that are bigger than needed
and also to wrongly formatted code.

Wolfgang Sourdeau wrote:
> NSCell:
> - whenever the cell type would change, the _contents ivar would be set
>   to @"title". I changed it to do that only when _contents is unset.
>   Besides, I was not sure if setting @"title" was very useful but I let
>   it that way in case there was a reason. This fixes the case where
>   NSToolbar with displayMode set to LabelOnly would redefine the item
>   labels to "title".

The second problem is a bit more important. The code currently in the
NSCell setType: method follows closely the Apple specification. So you
either need to proove that what Apple states is wrong, or you should
find another solution for your actual problem. In this case it should be
as simple as to overwrite the setType: method on tne NToolbarCell class
to do nothing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]