[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dfa.h / dfa.c diff versus gawk attached

From: Tony Abou-Assaleh
Subject: Re: dfa.h / dfa.c diff versus gawk attached
Date: Fri, 19 Oct 2007 00:02:59 -0300 (ADT)

Hi Arnold,

> Attached is a diff of the grep 2.5.3 dfa.h and dfa.c against the current
> version of same in the gawk CVS. (Or, it'll be in CVS within an hour or
> so. :-)

Thanks for the patch. BTW, I still don't see it committed on Savannah
gawk CVS.

> The changes fall into two categories: bug fixes, mostly having to do
> with multibyte character sets,

Can you point out or submit some test cases to demonstrate the bug and the
fix? Including them in the test set would reduce the chances of these
bugs resurfacing uncaught.

> and reviving the DFA matcher's ability
> to match across newlines, which grep doesn't need but which gawk does.
> This latter changes the interface to dfaexec.

Could you elaborate on this a bit? Grep already matches across newlines
with the -z option. If the current implementation is buggy, some test
cases would be appreciated.

Does the change to the dfaexec interface have any side effects or
implication on grep that are not taken care of by the patch?

I am not familiar with the code in dfa.[ch] and the patch looks
non-trivial. If there was some discussion about the patch on the gawk or
other lists, please point me in that direction.



Tony Abou-Assaleh
Email:    address@hidden
Web site: http://tony.abou-assaleh.net
----------------------[THE END]----------------------

reply via email to

[Prev in Thread] Current Thread [Next in Thread]