[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17420: [PATCH] grep: always convert fgrep to grep

From: Paul Eggert
Subject: bug#17420: [PATCH] grep: always convert fgrep to grep
Date: Wed, 07 May 2014 00:00:18 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Norihiro Tanaka wrote:
By the way, if `FGREP_NO_DFA' env. is set, fgrep still uses fgrep matcher.

I'd rather not introduce another environment variable. GREP_COLOR and GREP_COLORS and GREP_OPTIONS are now commonly considered to have been mistakes, and I'd rather not compound them.

Instead, how about removing the fgrep matcher entirely? That'll make the code simpler and easier to maintain, which is a real plus. Perhaps it'll be slower in a few cases, but as long as significant slowdowns are rare, that's OK.

Something like the attached patch, say.

Attachment: 0001-grep-simplify-by-removing-Fexecute-kwsearch.c-etc.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]