[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Grub Failure when HDD descriptor changes

From: Yoshinori K. Okuji
Subject: Re: Grub Failure when HDD descriptor changes
Date: Wed, 23 Mar 2005 21:41:25 +0100
User-agent: KMail/1.7.1

On Wednesday 23 March 2005 10:46 am, Molle Bestefich wrote:
> * lib/device.c (get_drive_geometry):
> Shuffle BLKGETSIZE and HD_GETGEO so that a correct sector count can
> be retrieved for device-mapper devices in the stage2 simulator.

You should be more explicit. Instead of saying just "shuffle", mention how you 
changed the code, like "first, do this, and if it fails, do that".

The code itself looks good, except for the coding style. The positions of 
braces are not good. Once you correct it, I will apply it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]