bug-guile
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GUILE_CFLAGS contains warning options


From: Ludovic Courtès
Subject: Re: GUILE_CFLAGS contains warning options
Date: Mon, 28 Feb 2011 00:43:37 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux)

Hi Bruno,

Bruno Haible <address@hidden> writes:

> 1) In this line
>        for flag in "$CPPFLAGS"
>    you should not use double-quotes, because the intent is to do 
> word-splitting
>    on the contents of $CPPFLAGS.

Oops.

>    next_is_includedir=false
>    for flag in $CPPFLAGS
>    do
>      if $next_is_includedir; then
>        GUILE_CFLAGS="$GUILE_CFLAGS -I $flag"
>        next_is_includedir=false
>      else
>        case "$flag" in
>          -I)  next_is_includedir=true;;
>          -I*) GUILE_CFLAGS="$GUILE_CFLAGS $flag";;
>          *)   ;;
>        esac
>      fi
>    done

Thanks, applied!

  
http://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.0&id=62cdb4e478d58ade852b04bdcfcf79c1ac815e21

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]