[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu-maintenance: Improve 'official-gnu-packages'; add the re

From: Ludovic Courtès
Subject: Re: [PATCH] gnu-maintenance: Improve 'official-gnu-packages'; add the related procedures.
Date: Wed, 27 Mar 2013 11:08:37 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Nikita Karetnikov <address@hidden> skribis:

>> You can if you end up not using the “syntactic constructor” with named
>> fields (as was the case in my example).
> Heh, I used it; it's very handy.  I didn't even try to use
> 'gnu-package-descriptor'.
> Thanks for your suggestions.  Any other comments?  If not, I'll create a
> proper patch (the attached version doesn't honor multiple fields).

Looks good to me!

Nitpicking follows:

> +  #:use-module (ice-9 rdelim)           ; http-fetch*

The comment is misleading.

> +  (gplv3-status     gnu-package-gplv3-status)
> +  (activity-status  gnu-package-activity-status)
> +  (last-contact     gnu-package-last-contact)
> +  (next-contact     gnu-package-next-contact)
> +  (note             gnu-package-note))

I’d remove these 5 fields since Brandon mentioned that at least 2 of
them are being moved elsewhere, and we don’t need them anyway.

(It’s surprising that there’s no ‘license’ field in the file.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]