[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27222: [PATCH] emacs-build-system install phase doesn't honor direct

From: Alex Kost
Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy
Date: Sun, 04 Jun 2017 22:41:43 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Maxim Cournoyer (2017-06-04 09:44 -0700) wrote:

>>>                        (phases '(@ (guix build emacs-build-system)
>>>                                    %standard-phases))
>>>                        (outputs '("out"))
>>> -                      (include ''("^[^/]*\\.el$" "^[^/]*\\.info$" 
>>> "^doc/.*\\.info$"))
>>> +                      (include ''("\\.el$" "^[^/]*\\.info$" 
>>> "^doc/.*\\.info$"))
>> As far as I understand it, it was done for purpose: some packages
>> include "uninteresting" (for tests, maintenance, etc.) *.el files in
>> subdirs, that's why they are excluded by default.  So probably a better
>> solution would be to fix 'ert-runner' package (as it is done in commit
>> b1d32ec0e23bfec1dab4c56909228a494b2b0d60, for example).  WDYT?
> I acknowledge the intent, but I think the default set of rexgeps
> should be more lenient; filtering (inoffensive) files is desirable, but
> not at the cost of breaking perfectly valid packages. That's one extra
> hurdle the packagers shouldn't have to bear in my opinion.
> This change also doesn't prevent excluding subfolders if they are truly
> unnecessary (such as tests subfolder), but this should happen due to
> explicit regexp in the exclude option, not because *all* subfolders are
> excluded.
> What do you think?

I think my view is not what most people would like: I am for excluding
as much as possible (as it is now), and for manual adjusting packages
when it is needed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]