[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27222: [PATCH] emacs-build-system install phase doesn't honor direct

From: Alex Kost
Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy
Date: Mon, 05 Jun 2017 23:07:52 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Arun Isaac (2017-06-05 00:55 +0530) wrote:

>> I also think these arguments are redundant!  I suggested to remove this
>> duplication at:
>>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#41
> And, I did respond at
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#53

Sure, I didn't mean I was ignored, I just wanted to say that I got the
same thought about those arguments as Maxim.

>> ... but I think the include/exclude arguments need to be duplicated in
>> two places. For example, look at arguments #:strip-flags and
>> #:strip-directories in the `strip' phase of the gnu-build-system. Even
>> there, the default values of the arguments are repeated in two places.
> Do you know of some way in which we can avoid duplication of the
> arguments?

As I said, I think this duplication can be avoided simply by removing
the values of 'include'/'exclude' arguments from 'install' procedures of
(guix build emacs-build-system) module.

> Even the gnu-build-system duplicates default values of arguments.

I don't know about gnu-build-system, but I don't see a reason to have
these values in 'install' procedure of emacs-build-system.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]