[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] settrans -gl only kills the active translator

From: Thomas Bushnell, BSG
Subject: Re: [PATCH] settrans -gl only kills the active translator
Date: 15 May 2001 15:08:17 -0700
User-agent: Gnus/5.0803 (Gnus v5.8.3) Emacs/20.7

Neal H Walfield <neal@cs.uml.edu> writes:

> > I have no objection to adding a flag for file_set_translator to avoid
> > sending the goaway.  But calling the flag "disconnect" is wrong: a
> > disconnect happens whether you set that flag or not.
> I fail to see how this is true: if the translator, in response to
> fsys_goaway, returns an error, diskfs_S_file_set_translator deallocates
> a user reference to the control port, which it obtained in
> fshelp_fetch_control, and returns the error.

That's an error condition.  My point is that whether or not you set this new
flag, a *successful* return always disconnects.  Whether you turn that
flag on or not, you are still requesting a disconnection.

> Most translators interpret fsys_goaway as meaning: shutdown (i.e. call
> exit).  Here, the disconnection is an obvious result of the exit.

All translators are supposed to interpret it that way.

> As far as I can tell, libdiskfs currently has no facility to disconnect
> an active translator from the file system (i.e. deallocate the user
> reference to the control port to the active translator) without also
> asking the filesystem to shutdown.

Yes, you are quite right that we need some new flag.  My point is that
the name "disconnect" isn't the best name.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]