bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: preprocessor/7947: cpp0 -std=gnu99 rejects # comments


From: Marcus Brinkmann
Subject: Re: preprocessor/7947: cpp0 -std=gnu99 rejects # comments
Date: Tue, 17 Sep 2002 22:14:45 +0200
User-agent: Mutt/1.4i

On Tue, Sep 17, 2002 at 01:00:02PM -0700, Jeff Bailey wrote:
> On Tue, Sep 17, 2002 at 09:45:09PM +0200, Marcus Brinkmann wrote:
> 
> > Ayup, I just see my mistake.  We are setting -std=gnu99 in CPPFLAGS,
> > not CFLAGS.  D'oh!  I will put the blame elsewhere then :)
> 
> CFLAGS is certainly the wrong place for this, because it's required
> for compilation (so it would violate the GCS).  Automake seems to
> provide AM_CFLAGS for this purpose, so that might not be a bad choice
> for a name.  (Or just keep the filter out for now).

We already violate the GCS on the CFLAGS issue (for example by relying on
optimization, see tasks file), this can be cleaned up in your automake patches. 
It's way simpler to put it in CFLAGS than introduce a new variable in the
current Makefiles.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    address@hidden
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]