[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: argp patch for the console client

From: Alfred M. Szmidt
Subject: Re: argp patch for the console client
Date: Wed, 10 Mar 2004 09:41:32 +0100 (MET)

I looked at the patch quickly, and you missed a couple ChangeLog
entries.  For example, you didn't document the (small) change you did
in beep_on(), you didn't document the interface in ncursesw.c for
ncursesw_driver_init(), or the one you did in pc-kbd.c for
pc_kbd_init(). There are probobly other cases I might have missed.

Double and tripple check! :-)

Out of curiousity, could you add a quick comment about why the code
you disabled got disabled (vga_display_change_font)?

Otherwise, it looks ok.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]