[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] _hurd_select: check for invalid parameter values

From: Roland McGrath
Subject: Re: [PATCH,HURD] _hurd_select: check for invalid parameter values
Date: Fri, 20 Jul 2012 10:23:26 -0700 (PDT)

>       * hurd/hurdselect.c (_hurd_select): Return EINVAL for negative
>       `timeout' values.
>       Return EINVAL for `nfds' values either negative or greater than
>       FD_SETSIZE.

In a log entry, write a local variable name as FOO rather than `foo'.

> +      to = timeout->tv_sec * 1000 +
> +        (timeout->tv_nsec + 999999) / 1000000;

When splitting a line in the middle of an expression, the operator goes on
the second line, not the first.  Add parentheses so that the second line
is indented to inside the opening parenthesis.  i.e.:

      to = (timeout->tv_sec * 1000
            + (timeout->tv_nsec + 999999) / 1000000);

With those cosmetic fixes, this change is fine.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]