[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurd: compliance fixes for getlogin_r

From: Roland McGrath
Subject: Re: [PATCH,HURD] hurd: compliance fixes for getlogin_r
Date: Fri, 20 Jul 2012 10:26:54 -0700 (PDT)

> > libc code can use C99 freely these days, so use an inline
> > initializing declaration rather than pre-declaring a new variable.
> Hm ok; is it bad if I leave them as it is, for now?

It's not terrible but there is no reason to let new code in that is not in
optimal style, and it's trivial to fix it.  So please do that and then
the change is fine to commit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]