[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finish

From: Richard Braun
Subject: Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished
Date: Wed, 13 Feb 2013 08:46:43 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Wed, Feb 13, 2013 at 07:24:46AM +0100, Svante Signell wrote:
> > We warned you several times about making your changes as little
> > intrusive as possible for easier review. Since you seem to be unable to
> > understand what that implies, it's only natural Samuel no longer wastes
> > time on this and simply replies "to long to go through it".
> I am able to understand, no problem. And I know that a patch this large
> can be difficult to review. Problem is that he did not give any hints on
> _how_ to make the rewrite. If introducing the SELECT_ERROR had been
> discussed (or allowed to introduce) my solution would have been
> different too. But I would still use the helper functions to improve
> readability (and maintainability).

Of course. That's our job to give you ideas.

About how to make the rewrite, well first we told you not to. Look at
the branch Samuel just created [1], it's not a rewrite, there only are a
few changes, quite simple to understand.

Richard Braun


reply via email to

[Prev in Thread] Current Thread [Next in Thread]