[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH hurd 0/6] Add file record locking support

From: Svante Signell
Subject: Re: [PATCH hurd 0/6] Add file record locking support
Date: Thu, 08 Jan 2015 13:55:28 +0100

On Thu, 2015-01-08 at 13:38 +0100, Justus Winter wrote:
> Hello Svante :)
> Quoting Svante Signell (2015-01-08 12:28:05)
> > Hi,
> > 
> > Attached in subsequent mails is a patch series for file record locking
> > support, mainly developed by Neal Walfield in 2001. The patch was
> > published by Marcus Brinkmann and later re-diffed by Michael Banck in
> > 2002. Now modified to use libpthread instead of cthreads and some
> > additional fixes.
> Cool.


> For my taste, the order of patches is wrong.  Please try to make sure,
> that the source tree compiles at every point.  If you add an RPC with
> the first patch, the build will break.  Instead, you have to add the
> server implementation first, and the RPC definition later.

Well, I was expecting that all patches should be applied (wneh modified
and OKed), not each one separately. I can fix that, but what's the use
of applying parts of patches in a patch series?

> Also, use git.  This isn't optional.  If you want to contribute to a
> free software project, you have to use the tools they use.  Not doing
> so breaks everyones workflow. 

Well, I'm not comfortable with git and did not know that it is even
mandatory to use for Hurd development. Where is that written down?
Samuel has previously accepted quilt-based patches, but that was for
debian-hurd not upstream hurd.

> I will not review patches that are not sent using git, but I'm only
> speaking for myself of course.

Too bad :(

reply via email to

[Prev in Thread] Current Thread [Next in Thread]