[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to support output synchronization under -j

From: Eli Zaretskii
Subject: Re: patch to support output synchronization under -j
Date: Thu, 14 Apr 2011 22:00:49 +0300

> Date: Thu, 14 Apr 2011 14:12:16 -0400
> From: David Boyce <address@hidden>
> Cc: address@hidden, address@hidden
> On Thu, Apr 14, 2011 at 1:48 PM, Eli Zaretskii <address@hidden> wrote:
> > David, can you explain why you needed to lock the files?  Also, what
> > region(s) of the file you are locking?  fcntl with F_WRLCK won't work
> > on Windows, so the question is how to emulate it.
> I was about to write this up but I see Paul beat me to it ...

Yes, but a few words about how is this semaphore supposed to get job
done, and in fact what kind of "synchronization" will this bring to
Make, would be appreciated.  I don't think you described the feature
too much in your original post.

> > Finally, I'd suggest that the system-dependent portions of sync_output
> > be factored out into a separate function, so that the Windows port
> > could have its own implementation without infesting job.c with yet
> > another bunch of #ifdef's.
> Agree. Ifdef bad. Just wanted to see if the feature would be favorably
> looked on first. I can't actually do the Windows etc ports but I could
> certainly refactor it with stubs.

If you refactor the Unix code, adding the Windows equivalent is easy,
so you don't even need to add stubs.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]