[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: gcc bug causes parted to write bad GPT entries

From: Matt_Domsch
Subject: RE: gcc bug causes parted to write bad GPT entries
Date: Tue, 19 Mar 2002 09:50:47 -0600

> That works quite well, and as an added bonus, the size of gpt_disk.o
> drops from 53K to 46K on ia64, -Os.

> I'll assume that we are going to take this approach, and post a new
> patch shortly.  I'm still of the view that we should treat 
> the GUIDs as raw 16 byte blobs.

Yes, I agree.  How it gets defined is interesting.
typedef efi_guid_t char[16];
typedef struct {
        u8 b[16];
} efi_guid_t;

Personally, I like the latter, as then you pass around a structure rather
than an array (which is already a pointer).

>  The structure of them is now only used inside your
> swap_uuid_and_efi_guid() function, so that would have to be 
> implemented some other way.

It could be done very similarly, just without the structure def.  It's just

> BTW, with my changes parted GPT support actually works on 
> big-endian; I
> partitioned a disk on ia64 and read the table on hppa.  No kernel
> support, so I couldn't actually use it - but the kernel code has the
> same 'crc after byteswap' problem anyway (as does debian 
> boot-floppies,
> as I lifted the parted code before I noticed the problem).

Doh!  I've got to make the kernel changes on all this too.  It's high on my
list.  Andries Brouwer (linux/fs/partitions maintainer) is busy teaching
class lately and hasn't had a chance to comment on the code, which I'm
trying to get pushed into the standard kernel and out of the IA-64 port.


Matt Domsch
Sr. Software Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#1 US Linux Server provider for 2001!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]