[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [parted] ped_partition_busy should not call the libparted exception
Re: [parted] ped_partition_busy should not call the libparted exception handler
Tue, 06 Oct 2009 11:54:02 +0200
Hans de Goede wrote:
> Modify libparted/arch/linux.c _partition_get_part_dev() to not call
> _device_stat() but instead use stat directly, as _device_stat() calls
> the libparted exception handler and we don't want this here, the only caller
> of _partition_get_part_dev() is _partition_is_mounted(), which in turn only
> gets called by linux_partition_is_busy(), and we don't want to "throw"
> exceptions from ped_partition_busy()
> This issue was noticed in combination with pyparted as used by anaconda, see:
I'm adding this to your commit.
If you'd like to adjust the wording, please let me know ASAP:
diff --git a/NEWS b/NEWS
index 89e8804..75b04c1 100644
@@ -18,6 +18,10 @@ GNU parted NEWS -*-
** Bug fixes
+ ped_partition_busy no longer calls libparted's exception handler,
+ since doing so caused trouble with anaconda/pyparted operating on
+ dmraid devices.
Partitions in a GPT table are no longer assigned the "microsoft
reserved partition" type. Before this change, each partition would
be listed with a type of "msftres" by default.