[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] Fix sv_isrchterm (set isearch-terminators) to
Re: [Bug-readline] [PATCH] Fix sv_isrchterm (set isearch-terminators) to check for NUL on the value string
Sun, 17 May 2015 20:49:57 -0400
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
On 5/16/15 11:26 PM, Sergio Durigan Junior wrote:
> However, it is not checking to see if v[end] is not NUL, which leads to
> a segmentation fault depending on what is on the stack when v gets
> allocated. FWIW, I managed to reproduce the failure using the inputrc
> file attached to this message.
> The patch to fix this issue is trivial. It just checks to see if v[end]
> is not NUL before proceeding with the whitespace check.
Thanks for the report. You have found one of the oldest bugs in readline:
that code has existed in more or less its current form for over 15 years.
> It seems that you are not using a ChangeLog file anymore, so I am
> sending only the patch. Please let me know if I need to send anything
Readline development is done along with bash, so the bash changelog (and
devel branch) contains the readline development history.
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU address@hidden http://cnswww.cns.cwru.edu/~chet/