[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] Fix sv_isrchterm (set isearch-terminators) to
Sergio Durigan Junior
Re: [Bug-readline] [PATCH] Fix sv_isrchterm (set isearch-terminators) to check for NUL on the value string
Mon, 18 May 2015 01:22:09 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
On Sunday, May 17 2015, Chet Ramey wrote:
> On 5/16/15 11:26 PM, Sergio Durigan Junior wrote:
>> However, it is not checking to see if v[end] is not NUL, which leads to
>> a segmentation fault depending on what is on the stack when v gets
>> allocated. FWIW, I managed to reproduce the failure using the inputrc
>> file attached to this message.
>> The patch to fix this issue is trivial. It just checks to see if v[end]
>> is not NUL before proceeding with the whitespace check.
> Thanks for the report. You have found one of the oldest bugs in readline:
> that code has existed in more or less its current form for over 15 years.
Hah, neat :-).
>> It seems that you are not using a ChangeLog file anymore, so I am
>> sending only the patch. Please let me know if I need to send anything
> Readline development is done along with bash, so the bash changelog (and
> devel branch) contains the readline development history.
Alright, I remember seeing someone commenting this on gdb-patches
indeed. So, should I send the patch to bug-bash, or is bug-readline
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible