Re: [Bug-tar] On upcoming release

[Jack Howarth]

On Tue, Mar 22, 2016 at 01:46:30PM -0400, Jack Howarth wrote:
> On Thu, Mar 17, 2016 at 10:45:28AM +0200, Sergey Poznyakoff wrote:
> > Hello,
> > 
> > I plan to release 1.29 within 7-10 days.  I'm aware of several still
> > pending issues, but these don't seem to be important enough to justify
> > further delays.  Please, correct me if I'm wrong.  Paul, Pavel - your
> > opinions?
> > 
> > Regards,
> > Sergey
> 
> Current tar git doesn't build here on x86_64-apple-darwin15 under clang from 
> Xcode 7.3...
> 

The build failures are suppressed on x86_64-apple-darwin15 with Xcode 7.3 by 
application of the proposed patch (adjusting for bit rot in the lib/xattr-at.c 
hunk)...

http://lists.gnu.org/archive/html/bug-tar/2014-08/txtB_H8f4It7m.txt

from http://lists.gnu.org/archive/html/bug-tar/2014-08/msg00003.html followed 
by re-executing the ./bootstrap command to regenerate configure. Is there some 
reason why this patch is always cited to darwin users but never actually 
committed into tar trunk to actually eliminated the build failures?

> make[3]: Entering directory '/Users/howarth/tar.git/lib'
>   CC       xattr-at.o
> In file included from xattr-at.c:42:
> ../gnu/at-func.c:75:12: error: too few arguments to function call, expected 
> 6, have 5
>     return CALL_FUNC (file);
>            ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
> int setxattr(const char *path, const char *name, const void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:42:
> ../gnu/at-func.c:93:35: error: too few arguments to function call, expected 
> 6, have 5
>         FUNC_RESULT proc_result = CALL_FUNC (proc_file);
>                                   ^~~~~~~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
> int setxattr(const char *path, const char *name, const void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:42:
> ../gnu/at-func.c:130:9: error: too few arguments to function call, expected 
> 6, have 5
>   err = CALL_FUNC (file);
>         ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
> int setxattr(const char *path, const char *name, const void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:54:
> ../gnu/at-func.c:75:12: warning: implicit declaration of function 'lsetxattr' 
> is invalid in C99 [-Wimplicit-function-declaration]
>     return CALL_FUNC (file);
>            ^
> ../gnu/at-func.c:44:24: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ^
> xattr-at.c:50:20: note: expanded from macro 'AT_FUNC_F1'
> #define AT_FUNC_F1 lsetxattr
>                    ^
> In file included from xattr-at.c:67:
> ../gnu/at-func.c:75:12: error: too few arguments to function call, expected 
> 6, have 4
>     return CALL_FUNC (file);
>            ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
> ssize_t getxattr(const char *path, const char *name, void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:67:
> ../gnu/at-func.c:93:35: error: too few arguments to function call, expected 
> 6, have 4
>         FUNC_RESULT proc_result = CALL_FUNC (proc_file);
>                                   ^~~~~~~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
> ssize_t getxattr(const char *path, const char *name, void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:67:
> ../gnu/at-func.c:130:9: error: too few arguments to function call, expected 
> 6, have 4
>   err = CALL_FUNC (file);
>         ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
> ssize_t getxattr(const char *path, const char *name, void *value, size_t 
> size, u_int32_t position, int options);
> ^
> In file included from xattr-at.c:81:
> ../gnu/at-func.c:75:12: warning: implicit declaration of function 'lgetxattr' 
> is invalid in C99 [-Wimplicit-function-declaration]
>     return CALL_FUNC (file);
>            ^
> ../gnu/at-func.c:44:24: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ^
> xattr-at.c:77:20: note: expanded from macro 'AT_FUNC_F1'
> #define AT_FUNC_F1 lgetxattr
>                    ^
> In file included from xattr-at.c:94:
> ../gnu/at-func.c:75:12: error: too few arguments to function call, expected 
> 4, have 3
>     return CALL_FUNC (file);
>            ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
> ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
> ^
> In file included from xattr-at.c:94:
> ../gnu/at-func.c:93:35: error: too few arguments to function call, expected 
> 4, have 3
>         FUNC_RESULT proc_result = CALL_FUNC (proc_file);
>                                   ^~~~~~~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
> ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
> ^
> In file included from xattr-at.c:94:
> ../gnu/at-func.c:130:9: error: too few arguments to function call, expected 
> 4, have 3
>   err = CALL_FUNC (file);
>         ^~~~~~~~~~~~~~~~
> ../gnu/at-func.c:44:60: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ~~~~~~~~~~                          ^
> /usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
> ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
> ^
> In file included from xattr-at.c:107:
> ../gnu/at-func.c:75:12: warning: implicit declaration of function 
> 'llistxattr' is invalid in C99 [-Wimplicit-function-declaration]
>     return CALL_FUNC (file);
>            ^
> ../gnu/at-func.c:44:24: note: expanded from macro 'CALL_FUNC'
> # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
>                        ^
> xattr-at.c:104:20: note: expanded from macro 'AT_FUNC_F1'
> #define AT_FUNC_F1 llistxattr
>                    ^
> 3 warnings and 9 errors generated.
> Makefile:1298: recipe for target 'xattr-at.o' failed
> make[3]: *** [xattr-at.o] Error 1
> make[3]: Leaving directory '/Users/howarth/tar.git/lib'
> Makefile:1241: recipe for target 'all' failed
> make[2]: *** [all] Error 2
> make[2]: Leaving directory '/Users/howarth/tar.git/lib'
> Makefile:1349: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/Users/howarth/tar.git'
> Makefile:1289: recipe for target 'all' failed
> make: *** [all] Error 2
>