[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Fail

From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures.
Date: Tue, 16 Jul 2013 20:52:01 +0530

Attaching a patch that fixes the above stated issue.

There are two regions that I would like to draw attention to:
1. http.c:3752 : The code is quite redundant and I would prefer that it was
somehow merged. Ideas on fixing this would be greatly appreciated!
2. http.c:2424 : There is a simple if-else statement here. I initially had
a ternary statement here like:
return AUTHFAILED?(auth_err == RETROK):auth_err;

However, instead of returning AUTHFAILED when auth_err is RETROK, the
function keeps returning NOCONNERROR. I am unable to understand why this
happens. Can anyone please explain?

Thanking You,
Darshit Shah

Attachment: 0001-Fix-Exit-Status-Codes-when-there-are-errors-in-Diges.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]