[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Fail

From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures.
Date: Mon, 22 Jul 2013 14:27:53 +0530

Please find attached a new patch incorporating your comments.

could you avoid this global?  Can we propagate instead a pointer as
> create_authorization_line and digest_authentication_encode param?
> Fixed as a pointer that is sent to create_authorization_line and
digest_authentication_encode as a param.

> > +          logprintf (LOG_NOTQUIET, _("Required attribute missing from
> Header receieved.\n"));
> s|receieved|received|
Typo. My bad. Fixed.

> Should we xfree_null (qop) before setting it to NULL?
> qop will ALWAYS be xfree'd if it is explicitly set to NULL. The if
statement on the next line takes care of that.
In the original code, we set user to NULL while it was xfree'd only at
termination time.

Thanking You,
Darshit Shah

Attachment: 0001-Fix-erroneous-error-codes-when-HTTP-Digest-Authentic.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]