[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [Bug-Wget][RFC] Improvements to parallel-wget branch

From: Darshit Shah
Subject: [Bug-wget] [Bug-Wget][RFC] Improvements to parallel-wget branch
Date: Wed, 4 Dec 2013 07:53:39 +0530

I have been working on making a few changes to the parallel-wget branch.
Currently, I am focused on getting all the tests implemented for parallel
wget and detection of race conditions. For this, I submit two patches.

The first patch, is merely a little cleanup. It removes the redundant
--enable-threads options in configure.ac since this option is already added
automagically for us by threadlib.m4 in GNULib. I have also added reporting
the status of Metalink Libraries in the configure status message.

The second patch needs a little more work. I am trying to get working on
Autotools, but this is one crazy project. I have small issue that isn't
working, if anyone can fix this for me, that'd be great!
I have added a new configure option, --enable-race-detection. This option
when enabled will compile Wget with certain flags which will spew a lot of
output to the screen on runtime in case it encounters potential race
conditions. Hence, this option should NEVER be used on production systems.
This option must only be used when debugging the code and it is preferable
to use this option when running the new Test Suite which has tests
specifically to fail when this is option is used.

I added the AC_ARG_ENABLE option to create a new command line switch to
configure. I also added an AM_CONDITIONAL to create a ENABLE_RACES variable
for use in Makefiles. But I can't get the if statements in the Makefile to
work correctly. Specifically, in the second patch, I have an if statement
in testenv/Makefile.am that adds a certain test to XFAIL_TESTS when
ENABLE_RACES is set. This condition does not seem to work. If anyone can
help me out here, I would be extremely grateful!

Thanking You,
Darshit Shah

Attachment: 0001-Build-changes.-Remove-redundant-enable-threads-optio.patch
Description: Text Data

Attachment: 0002-Add-new-configure-option-enable-race-checking.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]