[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget

From: Darshit Shah
Subject: Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget
Date: Tue, 18 Mar 2014 01:06:54 +0100

Hi Jure,

Thanks for your patches. However, I do have a few comments about the same:

1. Trailing Whitespaces: This is essentially extra whitespaces at the
end of a line or on a blank line. See [1] and [2] for more
2. The indentation is mostly right, but sometimes off.
3. Your first patch is missing a ChangeLog. Every commit must be
accompanied by a ChangeLog entry, no matter how trivial it is.
4. Your 2nd patch seems to revert things from the first one. This
usually means some cleanup is needed.

I'm not completely sure of some of the details of the lines you change
in your second patch, but they seem a little sketchy. I'll have to dig
into the code and check it out.

Also, for a non-trivial (>10 LoC) patch, you'll first need to submit
your copyright assignment to the FSF.
Giuseppe will arrange for the documents as soon as your patch is ready.

The code however, does fix a segfault and maybe a few compiler
warnings. When it fixes something, an explanation is usually a nice


On Mon, Mar 17, 2014 at 6:56 PM, Jure Grabnar <address@hidden> wrote:
> Hi,
> this patch fixes some of compiler warnings. I was uncertain for the
> remaining ones (5) - I believe some of them might be stubs for upcoming
> features.
>  Best Regards,
> Jure Grabnar (toomanysecrets)

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]