[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget

From: Jure Grabnar
Subject: Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget
Date: Sat, 22 Mar 2014 11:02:30 +0100


thank you for your feedback, Darshit, Yousong!

I reverted magic number back to its original state ('tmp2'), because it
be there (I overlooked that 'tmp' variable is changed in the very next

Duplicated line is removed.

I also changed resource->type to point at dynamic memory.

They say third's time's the charm. :) I hope it's ok now.


Jure Grabnar

On 21 March 2014 14:31, Yousong Zhou <address@hidden> wrote:

> Hi, Jure.
> On 21 March 2014 03:23, Jure Grabnar <address@hidden> wrote:
> > Thank you for you feedback Darshit. I changed my proposal according to
> your
> > advices. Hopefully a new version is better.
> >
> > I'm also sending corrected patches, again thanks to your review, Darshit.
> > First patch allows Metalink to have optional argument "type" in <url>
> > field. Where type is not present, it extracts protocol type from URL
> string.
> >
> On the 1st patch, static "char *" value should not be assigned to
> resource->type that will later be free()'ed.
>                yousong

Attachment: 0001-Fix-metalink-issues-when-type-is-not-present.patch
Description: Text Data

Attachment: 0002-Fix-some-compiler-warnings.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]