[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if availa

From: Tim Rühsen
Subject: Re: [Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if available
Date: Sat, 01 Nov 2014 14:22:06 +0100
User-agent: KMail/4.14.2 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; )

Am Samstag, 1. November 2014, 14:11:53 schrieb Darshit Shah:
> I'm in favour of using pkg-config for detection of these libraries and would
> like to see the manual checking code gone in a future release.
> If we're to merge these patches, all of them should be squashed into one
> since they all perform the same action. I've merged all the patches into a
> single one and added ChangeLog entry to its right place. If others agree,
> I'll push this patch.

Cool, I also would like to see support for pkg-config.

You could add pkg-config for libpsl as well into the patch and check if there 
are any other libraries missing.

Also, please consider using AC_SEARCH_LIBS instead of AC_CHECK_LIBS.
A good description why is here: https://autotools.io/autoconf/finding.html

Here is an example for libz:
AC_ARG_WITH(zlib, AS_HELP_STRING([--without-zlib], [disable gzip compression 
support]), with_zlib=$withval, with_zlib=yes)
if test $with_zlib != "no"; then
  AC_SEARCH_LIBS(deflate, z,
    [with_zlib=yes; AC_DEFINE([WITH_ZLIB], [1], [Use zlib])],
    [with_zlib=no;  AC_MSG_WARN(*** ZLIB was not found. You will not be able 
to use gzip (de)compression)])


Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]