[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] broken progressbar in 1.16

From: Darshit Shah
Subject: Re: [Bug-wget] broken progressbar in 1.16
Date: Mon, 3 Nov 2014 10:12:55 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

On 11/01, Michael Shigorin wrote:
On Sat, Nov 01, 2014 at 11:39:55PM +0530, Darshit Shah wrote:

Pulled; not there yet:

e-flightgear-201411   0%[                      ]   1,05M   286KB/s   eta 1h 41m
wget: progress.c:1161: create_image: Проверочное утверждение «count_cols (bp->buffer) 
<= bp->width» не выполнено.
zsh: abort      wget -c

(it's [Assertion "count_cols (bp->buffer) <= bp->width" failed] I think)

This is a new assertion I just added to ensure that the logic of the progress bar is correct. It's failure would imply that the progress bar exceeds the width of the screen which would lead to new line spam.

I've filtered the patch to exclude changelog hunk and applied
it on top of 1.16 release; the downloaded size is 1168780 of
1599602688 bytes, the image is (my homegrown testing one)

Second run resulted in 1002020 bytes downloaded with the same failure.

This bug keeps getting more interesting and surprising. While the progress bar draws correctly for the original file you mentioned, the assertion fails with the new ISO (live-flightgear). The funny thing is, this bug is now firing based on the filename of the file being downloaded, which is not something I expect since the filename section of the progress bar is isolated from the rest and should not create such an effect.

I'm going to spend some more time debugging this issue.

 ---- WBR, Michael Shigorin / http://altlinux.org
  ------ http://opennet.ru / http://anna-news.info

--- end quoted text ---

Thanking You,
Darshit Shah

Attachment: pgpoQhjJs3BvU.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]