[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

From: Tim Rühsen
Subject: Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale
Date: Wed, 19 Nov 2014 19:37:43 +0100
User-agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )

Am Mittwoch, 19. November 2014, 22:21:12 schrieb Darshit Shah:
> On 11/18, Tim Rühsen wrote:
> >I amended three tests to fail when run with turkish locale.
> >I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced
> >strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places where we
> >definitely want a ASCII comparison instead of a locale dependent one.
> >
> >There are still some places left where we use strcasecmp/strncasecmp, e.g.
> >domain/host and filename comparisons.
> >
> >Please have a look...
> >
> >Tim
> In cookies.c, the header file is added on the same line as the ^L Page break
> character. Please add the file before the Page Break.
> I'm assuming your editor didn't show you that character, but git diff does.
> Try to enable such invisible characters in your editor.

No, you are right. Vi shows it, my IDE does not.
Dumb question: I never saw ^L in source code. What is it good for ? Printing ?

> Apart from that, it looks like a good patch. Please push it when you can

Thanks, I'll have some time in a few hours.


Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]