[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

From: Darshit Shah
Subject: Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale
Date: Thu, 20 Nov 2014 00:38:28 +0530

Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 20-Nov-2014 12:07 am, "Tim Rühsen" <address@hidden> wrote:
> Am Mittwoch, 19. November 2014, 22:21:12 schrieb Darshit Shah:
> > On 11/18, Tim Rühsen wrote:
> > >I amended three tests to fail when run with turkish locale.
> > >I fixed these issues (using c_strcasecmp/c_strncasecmp) and also
> > >strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places where we
> > >definitely want a ASCII comparison instead of a locale dependent one.
> > >
> > >There are still some places left where we use strcasecmp/strncasecmp,
> > >domain/host and filename comparisons.
> > >
> > >Please have a look...
> > >
> > >Tim
> >
> > In cookies.c, the header file is added on the same line as the ^L Page
> > character. Please add the file before the Page Break.
> >
> > I'm assuming your editor didn't show you that character, but git diff
> > Try to enable such invisible characters in your editor.
> No, you are right. Vi shows it, my IDE does not.
> Dumb question: I never saw ^L in source code. What is it good for ?
Printing ?
The GNU coding conventions require those. They are apparently for
demarcating pages. Most probably for printing I'd guess
> > Apart from that, it looks like a good patch. Please push it when you can
> Thanks, I'll have some time in a few hours.
> Tim

reply via email to

[Prev in Thread] Current Thread [Next in Thread]