[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] 'Saving HSTS entries to' bug
From: |
Ander Juaristi |
Subject: |
Re: [Bug-wget] 'Saving HSTS entries to' bug |
Date: |
Tue, 24 May 2016 11:23:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Hi Tim,
On 24/05/16 10:24, Tim Ruehsen wrote:
> Hi Ander,
>
> IMO, another possibility is to add a flag to 'struct hsts_store' that
> indicates any change made. hsts_store_save() could be skipped if that flag is
> not set.
>
> At the same time the debug info has to be moved from main.c/save_hsts() to
> hsts.c/hsts_store_save() OR hsts.c needs another function to return the value
> of the flag, so that save_hsts() could check it.
>
You mean something like the attached?
> WDYT ?
That could be an option. But I'm not sure we can skip the call to
hsts_store_save at all, because doing so would also mean not updating
the in-memory HSTS database, which might have been modified by other
wget processes.
We could also test whether there have been such changes (within
hsts_store_save), and then call hsts_store_dump only if affirmative. But
again, I don't think it pays off for the sole reason of removing a debug
message.
>
> Tim
>
0001-Correct-HSTS-debug-message.patch
Description: Text Data
- [Bug-wget] 'Saving HSTS entries to' bug, vaseleos0, 2016/05/21
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/21
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/23
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug,
Ander Juaristi <=
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/24
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Ander Juaristi, 2016/05/25
- Re: [Bug-wget] 'Saving HSTS entries to' bug, Tim Ruehsen, 2016/05/26