Re: [Bug-wget] 'Saving HSTS entries to' bug

[Tim Ruehsen]

Tim

On Tuesday 24 May 2016 11:23:42 Ander Juaristi wrote:
> Hi Tim,
> 
> On 24/05/16 10:24, Tim Ruehsen wrote:
> > Hi Ander,
> > 
> > IMO, another possibility is to add a flag to 'struct hsts_store' that
> > indicates any change made. hsts_store_save() could be skipped if that flag
> > is not set.
> > 
> > At the same time the debug info has to be moved from main.c/save_hsts() to
> > hsts.c/hsts_store_save() OR hsts.c needs another function to return the
> > value of the flag, so that save_hsts() could check it.
> 
> You mean something like the attached?

Yes :-)
I'll have a closer look at it later.

> > WDYT ?
> 
> That could be an option. But I'm not sure we can skip the call to
> hsts_store_save at all, because doing so would also mean not updating
> the in-memory HSTS database, which might have been modified by other
> wget processes.

We call hsts_store_save() shortly before exiting wget.
At that point, we don't need an in-memory update.

Also, if nothing changed in the hsts store, we simply don't have to care if 
other instances of wget changed the HSTS database.

Thanks for the quick response.

Tim