[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-zile] Re: small patches

From: Giuseppe Scrivano
Subject: [Bug-zile] Re: small patches
Date: Tue, 02 Mar 2010 17:32:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux)

Reuben Thomas <address@hidden> writes:

> As far as I can tell, the point of using the xlist module is that it
> catches out of memory errors, is that correct? I have used it. I have
> also removed an include of "gl_list.h" from variables.c, which doesn't
> need it, as it already includes main.h; it seems that extern.h should
> also include gl_xlist.h.

Right, xlist catches memory errors.

>> 3) If LUA is not found, signal an error, configure will not succeed.
> I don't understand this change: Lua is not needed to build released
> sources, only git sources.

sorry I misunderstood it, I agree the patch shouldn't be applied.

> I have recently noticed a cosmetic problem in Zile which I will now
> try to fix, so if you want to make any further comments, please do so
> quickly, before the next release!

I'll continue playing with zile at evening and I'll let you know if I
have other comments.

By the way, git formatted patches can be applied directly using the
command "git am file.patch", the advantage is that the time and the
author will be preserved.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]