Re: [Bug-zile] Crash on file oddities fixed?

[Gary V. Vaughan]

Hi Reuben,

On Wed, Apr 13, 2011 at 01:16:44PM +0100, Reuben Thomas wrote:
> On 13 April 2011 02:41, Gary V. Vaughan <address@hidden> wrote:
> > Still looks like a fixable Lua bug to me.  HEAD now gives me two
> > terminal bells and a very short-lived error message flashes up in
> > the minibuffer:
> >
> >  cannot make backup file: %s
> >
> > Quickly overwritten by:
> >
> >  Wrote /Users/me/.mutt/muttrc
> >
> > So a few things are still wrong:
> >
> >  i) posix.errno() is not returning an error message at file.lua:369
> 
> No, it's a missing call to string.format. I've added this one and a
> couple of others I found by grepping.

Nice catch.  And now I get a useful (although puzzling!) error message
when I edit a file in a non-root filesystem:

 $ mount
 ...
 /dev/disk0s2 on / (hfs, local, journaled)
 /dev/disk1s9 on /Volumes/InBox (hfs, local, nodev, nosuid, journaled, 
noowners, mounted by leviathan)
 $ ~/Devo/zile--savannah--lua/src/zile /Volumes/InBox/dotrc/mutt/muttrc
 ...
 [Cannot make backup file: Cross-device Link]
 <half-second pause>
 [Wrote /Volumes/InBox/dotrc/mutt/muttrc]

> >  ii) copy_file is not working at file.lua:365
> 
> So it looks like create_backup_filename is failing.

I haven't looked terribly hard, but it's not obvious to me why Zile is
happy to write the actual file I'm saving, but chokes when trying to
write a backup file - presumably a 'muttrc~' right next door to the file
it just successfully saved!

I'd be interested if you can recreate with a loopback device on Linux,
and wonder whether the mount options the OS is using here on my Mac are
in some way responsible? Although, I doubt it... since C Zile and Emacs
both work correctly.  Either way, I'll look into this properly as soon
as I get the chance.

> > iii) waitkey is not waiting for a key before overwriting the partial
> >     error message at file.lua:370
> 
> On the whole waitkey seems to me to work, and I'm at a loss to see
> what could be going wrong at this particular site (unless you're
> pressing a key!) so more help welcomed...

Does waitkey block the entire process?  The 'Wrote /Volumes[...]muttrc'
message faithfully sits in the minibuffer until I press a key, but it
definitely overwrites the actually error message very quickly!  I'll
see if I can get any further undestanding this one too in due course...

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)

pgp_zEdtZ1kkb.pgp
Description: PGP signature