[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch: image loading fixes
From: |
Tom Tromey |
Subject: |
Re: Patch: image loading fixes |
Date: |
11 Nov 2003 14:52:21 -0700 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
>>>>> "Tom" == Thomas Fitzsimmons <address@hidden> writes:
Tom> Are the attached changes to Component.java ok? If so, I'll check them
Tom> in along with the rest of the patch.
Looks great, just a couple little nit...
Tom> + transient private static boolean incrementalDraw;
Should be "private static transient", I think. The canonical
ordering is defined by Modifier.toString().
Tom> + if ((flags & (FRAMEBITS|ALLBITS)) != 0)
You need spaces around the "|". There are a few instances of this.
Tom