[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] NumberFormat

From: Mark Wielaard
Subject: Re: [PATCH] NumberFormat
Date: Sat, 22 Nov 2003 08:29:24 +0100


On Sat, 2003-11-22 at 00:11, Dalibor Topic wrote:
> Looks good to me in general, I have small remarks before you check it in:

Same here. Please check it in. Just one little nitpick.

> > +    protected Object readResolve() throws InvalidObjectException
> > +    {
> > +      String s = getName();
> > +      for (int i=0;i<allFields.length;i++)
> > +   if (s.equals(allFields[i].getName()))
> > +     return allFields[i];

Indenting looks a bit off, but that could be the diff and the
commenting. Please add spaces between the elements of the for loop and
(assignment) operators.

        for (int i = 0; i < allFields.length; i++)

> Finally, the mean question: do we have mauve tests for those? If not, 
> would you write some, please, so that gcj devs don't go ahead again and 
> re-implement everything from scratch as they tend to do ;)? [2]

Your [2] note reference is missing. Don't you like us writing Mauve test
cases for you? (Although I doubt you could create a very good one here,
only the (de)serialization is a little interesting.)

> dalibor topic,
> who is eager to write his own patch to the java/text/ 
> (equals) method's comment as soon as he's finished playing virtual mjw ;)

You are getting quite good at it!

> [1] I devote this pun to ricky clarckson. Mark, how are his 
> documentation patches coming along?

That was a terrible pun...
Ricky is working through the bureaucrazies, he will not give up, he will
not be defeated, and he will do it when he is ready :)



Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]