Re: [PATCH] Two methods for NumberFormat

[Mark Wielaard]

Hi Guilhem,

On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote:
> I am continuing the series of patches with that one, it adds two methods 
> to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). 
> They have to be implemented according to Java 1.4.

Thanks for splitting this up in small chunks.
Three small comments:
- You forgot a ChangeLog entry.
- Don't forget to update the copyright year.
- The second comment says 'default locale', should be 'desired locale'.
But besides that it looks fine to me. Please check it in.

(I would like to see us not use a space between the method and the
bracket beginning the argument list. But this class already had that and
jalopy will hopefully catch all this in the future for us.)

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part