[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] Indent maybe_os stuff ahead of refactor

From: John Ericson
Subject: Re: [PATCH 2/4] Indent maybe_os stuff ahead of refactor
Date: Wed, 2 May 2018 22:38:08 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Sure, then I'll momentarily send just two patches. The first will be the first 3 from before squashed, without reindenting that other case I don't already need to change. The second will be just as before but for convenience. In both cases, I'll rewrap and reindent only code that is now nested deeper and so needs to be changed anyways.


On 05/02/18 14:52, Ben Elliston wrote:
On Tue, May 01, 2018 at 04:12:18PM -0400, John Ericson wrote:

Sure, but I'm a bit confused on what you intended. There's a mix of
tabs and spaces which leads me to think you are using 4 space indent
with a tab for every 8 spaces? But the rest of the file looks like
it is using a tab per indent level (such that the spaces/tab doesn't
matter), where 4 spaces/tab is intended so the indent visually
matches what you did.
Just mimic what is already there. What's there doesn't match what my
Emacs shell-scipt-mode wants to with formatting, but I am not inclined
to disturb the file unecessarily.  It's been fine this way for 25
years. :-)

Thanks, Ben

reply via email to

[Prev in Thread] Current Thread [Next in Thread]