[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2

From: Jim Meyering
Subject: Re: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2
Date: Fri, 09 Apr 2010 16:03:54 +0200

jeff.liu wrote:
> Please ignore the previous patchsets, there is an issue I just fixed.
> Subject: [PATCH 1/2] Add fiemap.h for fiemap ioctl(2) support.

While reading through HACKING, bear in mind some implied
requirements for new features.  You should:

  - document it in NEWS
  - document it in coreutils.texi
  - add (or at least outline in detail) tests to demonstrate and/or
      exercise as much of the new code as possible

You needn't start the doc changes just yet, but outlining a few
simple tests (in the form of portable bourne shell scripts) would
be welcome.  Do not assume that "." is on the required type of file
system.  See below.

Re testing, here are some approaches.
The more you take the better.

  - skip the test if the current file system is not the required type
     (this is good because it will be run by non-root users, and hence
     gets more coverage than root-only tests)
  - find an existing, writable directory on a file system of the
     required type, else skip
  - (root-only) create a temporary, file system just to test this feature.
     Skip if the file-system-creation tool is not installed.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]